Skip to content

Conversation

sean-perkins
Copy link
Contributor

Issue number: Internal


What is the current behavior?

We currently export two versions of the ion-back-button angular implementation: IonBackButton and IonBackButtonDelegate.

What is the new behavior?

  • Removes IonBackButtonDelegate in favor of IonBackButton

Does this introduce a breaking change?

  • Yes
  • No
  • The IonBackButtonDelegate class has been removed in favor of IonBackButton.

    - import { IonBackButtonDelegate } from '@ionic/angular';
    + import { IonBackButton } from '@ionic/angular';

Other information

@github-actions github-actions bot added the package: angular @ionic/angular package label Feb 13, 2024
@sean-perkins sean-perkins marked this pull request as ready for review February 13, 2024 01:25
@sean-perkins sean-perkins requested review from a team and thetaPC as code owners February 13, 2024 01:25
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-perkins sean-perkins merged commit 6baf005 into feature-8.0 Feb 14, 2024
@sean-perkins sean-perkins deleted the sp/FW-5889 branch February 14, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants