Update dependencies#8
Merged
mlynch merged 5 commits intoionic-team:masterfrom Nov 16, 2018
simonhaenisch:update-dependencies
Merged
Update dependencies#8mlynch merged 5 commits intoionic-team:masterfrom simonhaenisch:update-dependencies
mlynch merged 5 commits intoionic-team:masterfrom
simonhaenisch:update-dependencies
Conversation
Contributor
|
w00t! Thanks for the PR. Will do a release at some point in the next two weeks (absolutely slammed rn) |
This was referenced Nov 16, 2018
|
@mlynch release pl0x? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to
@ionic/core@4.0.0-beta.15and@stencil/core@0.15.2. Also fixes and improves thecameratests, and did some maintenance.We are currently building a PWA project and need this to work with the latest Ionic and Stencil, but at the moment some of the types (e. g.
HTMLIonNavElement) clash if this is being used along with a different Ionic version.Closes #7, closes #4.
I linked this locally against my project and it works.
I'm not sure how to solve this in the long term for the case of using this within Ionic/Stencil projects... was thinking
peerDependenciesfirst, which should be fine as long as Ionic follows semver for breaking changes, i. e.{ "peerDependencies": { "@ionic/core": "^4.0.0-beta.12" } }would allow to build this with anything between4.0.0-beta.12and5. However the beta might still introduce breaking changes, and I don't know how the actualdistbuild would work if those are just peer dependencies.