Prevent slide right on last and left on first #1405
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When continuous was disabled, user could slide right on last or left on first and they received empty view. Problem was of the order of operations which calculate isPastBounds. a = true b = true c = false d = false earlier it was calculate: a && b | c && d = true | false && false = true & false = false after change (a && b) | (c && d) = true | false = true
|
My fault, I changed this to fix jshint errors. I'll review this a little later today and see if we can merge it. Thanks @evenemento ! |
ghost
assigned
ajoslin
added a commit
that referenced
this pull request
May 19, 2014
|
Fixed via ec5a276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When continuous was disabled, user could slide right on last or left on first and they received empty view.
Problem was of the order of operations which calculate isPastBounds.
a = true
b = true
c = false
d = false
earlier it was calculate:
a && b | c && d = true | false && false = true && false = false
after change
(a && b) | (c && d) = true | false = true