Skip to content

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 25, 2020

blocks ionic-team/ionic-docs#1356

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #17824

What is the new behavior?

  • Added feature to allow multiple handlers to be processed sequentially
  • Added docs with examples
  • Added tests

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added package: angular @ionic/angular package package: core @ionic/core package labels Feb 25, 2020
@brandyscarney
Copy link
Member

Is this considered a feature? Seems more like a bug fix?

Code looks good! Added @elylucas for reviewing React but looks like it should work fine.

@liamdebeasi
Copy link
Contributor Author

@brandyscarney I made it a feature since it adds a new parameter to the callback, but if you think it's more of a bug fix I'm fine with that too.

@liamdebeasi liamdebeasi requested a review from mhartington April 27, 2020 14:05
@liamdebeasi liamdebeasi merged commit 3821c04 into master Apr 27, 2020
@liamdebeasi liamdebeasi deleted the hardware-back-button-feat branch April 27, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants