fix: default export a function in global script #720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
ionic-pwa-toolkit
starter fails to build (at least with@stencil/core@1.3.0
but I think already before that) because of theionicons
dependency:To fix that, this PR:
For the last point, please check whether that's ok. The reason is that I wasn't able to build the project because the
icons
folder was missing until thebuild.data
script had been run (which generates thaticons
folder. Might be related to 8839341.To make the pwa-toolkit starter work again, the following actions have to be taken:
ionicons
dependency in the@ionic/core
package@ionic/core
version@ionic/core
dependency inionic-pwa-toolkit