[Repo Assist] feat: add code fix for adding missing seq before {…} (fixes #1333 CI)#1474
Merged
Krzysztof-Cieslak merged 4 commits intomainfrom Feb 26, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist, rebasing and fixing the CI for #1333.
Summary
This PR takes the work from #1333 (by @edgarfgp), rebases it on the current
main, and fixes the CI failures that prevented the original PR from merging.Closes #1330
Root Cause of CI Failure
The CI was failing because Fantomas formatting checks failed on two files:
src/FsAutoComplete/CodeFixes/AddMissingSeq.fs needs formattingsrc/FsAutoComplete/LspServers/AdaptiveServerState.fs needs formattingAdditionally, the PR branch was behind
main(there was a merge conflict inTests.fsdue to the addition ofAddMissingWildcardOperatorTestsonmain).Changes
seqbefore {…} #1333 on top of currentmainTests.fsto include bothAddMissingWildcardOperatorTestsandAddMissingSeqTestsdotnet fantomasto fix formatting in:src/FsAutoComplete/CodeFixes/AddMissingSeq.fssrc/FsAutoComplete/LspServers/AdaptiveServerState.fstest/FsAutoComplete.Tests.Lsp/CodeFixTests/AddMissingSeqTests.fsWhat the Feature Does
Adds a new code fix
AddMissingSeqthat handles diagnostic codesFS3873andFS0740— suggesting to add the missingseqkeyword before{…}expressions like:{ 1..10 }→seq { 1..10 }{ 1..10..20 }→seq { 1..10..20 }{ 1; 10 }→seq { 1; 10 }Test Status
✅ Build:
⚠️ Tests: Full test suite not run (takes too long in CI environment), but the feature logic is identical to the original PR with formatting applied.
dotnet build -c Release— succeeded with 0 errors✅ Formatting:
dotnet fantomas --check build.fsx src— passedAll credit for the implementation goes to @edgarfgp.