Skip to content

[Repo Assist] feat: add code fix for adding missing seq before {…} (fixes #1333 CI)#1474

Merged
Krzysztof-Cieslak merged 4 commits intomainfrom
repo-assist/fix-1333-add-missing-seq-bfe563fb749f7db1
Feb 26, 2026
Merged

[Repo Assist] feat: add code fix for adding missing seq before {…} (fixes #1333 CI)#1474
Krzysztof-Cieslak merged 4 commits intomainfrom
repo-assist/fix-1333-add-missing-seq-bfe563fb749f7db1

Conversation

@github-actions
Copy link
Contributor

🤖 This is an automated PR from Repo Assist, rebasing and fixing the CI for #1333.

Summary

This PR takes the work from #1333 (by @edgarfgp), rebases it on the current main, and fixes the CI failures that prevented the original PR from merging.

Closes #1330

Root Cause of CI Failure

The CI was failing because Fantomas formatting checks failed on two files:

  • src/FsAutoComplete/CodeFixes/AddMissingSeq.fs needs formatting
  • src/FsAutoComplete/LspServers/AdaptiveServerState.fs needs formatting

Additionally, the PR branch was behind main (there was a merge conflict in Tests.fs due to the addition of AddMissingWildcardOperatorTests on main).

Changes

  • Rebased original 3 commits from Add a code fix for adding missing seq before {…} #1333 on top of current main
  • Resolved merge conflict in Tests.fs to include both AddMissingWildcardOperatorTests and AddMissingSeqTests
  • Applied dotnet fantomas to fix formatting in:
    • src/FsAutoComplete/CodeFixes/AddMissingSeq.fs
    • src/FsAutoComplete/LspServers/AdaptiveServerState.fs
    • test/FsAutoComplete.Tests.Lsp/CodeFixTests/AddMissingSeqTests.fs

What the Feature Does

Adds a new code fix AddMissingSeq that handles diagnostic codes FS3873 and FS0740 — suggesting to add the missing seq keyword before {…} expressions like:

  • { 1..10 }seq { 1..10 }
  • { 1..10..20 }seq { 1..10..20 }
  • { 1; 10 }seq { 1; 10 }

Test Status

Build: dotnet build -c Release — succeeded with 0 errors
Formatting: dotnet fantomas --check build.fsx src — passed
⚠️ Tests: Full test suite not run (takes too long in CI environment), but the feature logic is identical to the original PR with formatting applied.

All credit for the implementation goes to @edgarfgp.

Generated by Repo Assist

To install this workflow, run gh aw add githubnext/agentics/workflows/repo-assist.md@f2c5cf1e4af58e09a93ba0703c6bf084711b265f. View source at https://github.com/githubnext/agentics/tree/f2c5cf1e4af58e09a93ba0703c6bf084711b265f/workflows/repo-assist.md.

@Krzysztof-Cieslak Krzysztof-Cieslak marked this pull request as ready for review February 26, 2026 11:18
@Krzysztof-Cieslak Krzysztof-Cieslak enabled auto-merge (squash) February 26, 2026 11:18
@Krzysztof-Cieslak Krzysztof-Cieslak merged commit 8907736 into main Feb 26, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a code fix for adding missing seq before {…}

2 participants