allow rollforwards, and unify proj-info versions since they'd drifted#818
Merged
baronfel merged 1 commit intoionide:masterfrom Jul 25, 2021
Merged
allow rollforwards, and unify proj-info versions since they'd drifted#818baronfel merged 1 commit intoionide:masterfrom
baronfel merged 1 commit intoionide:masterfrom
Conversation
Contributor
Author
|
The good news is that this should just work if the user has only 6.x sdks/runtimes installed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables FSAC to rollforward to different major versions of the framework. This builds on Enrico's earlier work. It's required because the msbuild locator utility we use has an implicit cap of the reported System.Environment.Version, so FSAC itself needs to be run on .net 6.
Coupled with this change, we need a change to ionide to allow setting additional .net cli args, because users will have to set
--fx-version <desired 6.0 runtime version>in order for things to work on .net 6.I think this will continue to be the case even after the 6.x stables, and at some point we may need to put out a 6.x build, but this at least patches over the cracks.