Skip to content

Remove duplicate version from generator config#14

Merged
splch merged 2 commits into
mainfrom
remove-duplicate-version
Apr 23, 2026
Merged

Remove duplicate version from generator config#14
splch merged 2 commits into
mainfrom
remove-duplicate-version

Conversation

@splch
Copy link
Copy Markdown
Collaborator

@splch splch commented Apr 23, 2026

Summary

  • Remove package_version_override from openapi-python-client-config.yaml
  • pyproject.toml is already the single source of truth for the package version
  • The generator does not embed this value into any generated source files, so the field was purely redundant and a drift risk

Verification

  • Regenerated the client from the vendored spec - output is identical
  • All 218 tests pass at 100% coverage

Test plan

  • Regenerate client, confirm no diff in generated code
  • Run full test suite

splch added 2 commits April 22, 2026 21:27
pyproject.toml is already the single source of truth for the package
version. The generator does not embed this value into any generated
source files, so the field was purely redundant and a drift risk.
Drop *.pyc (redundant with __pycache__/) and .mypy_cache/ (project
uses ty, not mypy).
@splch splch merged commit 0780bff into main Apr 23, 2026
7 checks passed
@splch splch deleted the remove-duplicate-version branch April 23, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant