Add unit test for null byte injected into a string token#30
Merged
Conversation
Adds test_null_byte_in_string_value() which constructs the payload
{"key": "val\0ue"} as an explicit char array (bypassing C string-literal
truncation) and asserts that okj_parse() returns OKJ_ERROR_UNEXPECTED_END.
The parser's string-scan loop condition checks != '\0', so it exits as
soon as the embedded null byte is reached — before the closing '"' is
seen. The post-loop check then finds '\0' at the current position and
returns OKJ_ERROR_UNEXPECTED_END, confirming that the null byte is caught
rather than silently truncating the token.
https://claude.ai/code/session_01QE8StsdbAm8BWdKrb7PpxV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test_null_byte_in_string_value() which constructs the payload {"key": "val\0ue"} as an explicit char array (bypassing C string-literal truncation) and asserts that okj_parse() returns OKJ_ERROR_UNEXPECTED_END.
The parser's string-scan loop condition checks != '\0', so it exits as soon as the embedded null byte is reached — before the closing '"' is seen. The post-loop check then finds '\0' at the current position and returns OKJ_ERROR_UNEXPECTED_END, confirming that the null byte is caught rather than silently truncating the token.
https://claude.ai/code/session_01QE8StsdbAm8BWdKrb7PpxV