test: add RFC 8259 bare control character rejection tests#40
Merged
Conversation
Add two tests that prove the < 0x20U boundary check in the string-scan loop correctly returns OKJ_ERROR_BAD_STRING without crashing: - test_control_char_tab_in_string_value: injects a literal horizontal-tab byte (0x09) inside a JSON string value via a hex escape in a string literal. - test_control_char_lf_in_string_value: injects a literal line-feed byte (0x0A, i.e. the raw byte — not the \n escape sequence) inside a JSON string value, built as an explicit char array to make the injection unambiguous. Both bytes satisfy 0xXX < 0x20U, so the parser must reject them per RFC 8259 §7 which forbids unescaped control characters U+0000–U+001F. https://claude.ai/code/session_01Vr1Jm2ua9DbFizRM936Gdf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two tests that prove the < 0x20U boundary check in the string-scan loop correctly returns OKJ_ERROR_BAD_STRING without crashing:
test_control_char_tab_in_string_value: injects a literal horizontal-tab byte (0x09) inside a JSON string value via a hex escape in a string literal.
test_control_char_lf_in_string_value: injects a literal line-feed byte (0x0A, i.e. the raw byte — not the \n escape sequence) inside a JSON string value, built as an explicit char array to make the injection unambiguous.
Both bytes satisfy 0xXX < 0x20U, so the parser must reject them per RFC 8259 §7 which forbids unescaped control characters U+0000–U+001F.
https://claude.ai/code/session_01Vr1Jm2ua9DbFizRM936Gdf