Skip to content

Add @iopipe/event-info.eventType for all key events #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolanos merged 1 commit into from
Sep 25, 2018
Merged

Add @iopipe/event-info.eventType for all key events #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion iopipe/contrib/eventinfo/event_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,12 @@ def has_required_keys(self):

def collect(self):
if self.keys == "all":
return collect_all_keys(
event_info = collect_all_keys(
self.event, "@iopipe/event-info.%s" % self.type, self.exclude_keys
)
event_info["@iopipe/event-info.eventType"] = self.type
return event_info

event_info = {}
for key in self.keys:
if isinstance(key, tuple):
Expand Down
9 changes: 6 additions & 3 deletions tests/contrib/eventinfo/test_event_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,12 @@ def test__event_types__alexa_skill(event_alexa_skill):
assert event.has_required_keys() is True

event_info = event.collect()
assert event_info != {}
assert all([k.startswith("@iopipe/event-info.alexaSkill.") for k in event_info])
assert len(list(event_info.keys())) == 31
expected_keys = ["@iopipe/event-info.eventType"] + [
"@iopipe/event-info.alexaSkill.%s" % key for key in event.keys
]
assert list(event_info.keys()).sort() == expected_keys.sort()

assert len(list(event_info.keys())) == 32


def test__event_types__apigw(event_apigw):
Expand Down