Viewer UX improvements: unit selector, clippy fixes, metadata cleanup#802
Merged
thinkingfish merged 7 commits intoiopsystems:mainfrom Apr 18, 2026
Merged
Conversation
… fix Add node selection to the WASM site viewer (file_metadata_json, parseNodeList, changeNode) so combined parquet files can switch between nodes. Wrap bare cpu_cores references in sum() across all dashboard queries to fix PromQL label-matching when node labels are injected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Inject node label into cgroup queries so charts scope to selected node - Inject node label into query explorer and single chart view queries - Fix site viewer loadSection missing sectionRoute for node injection - Add unit type selector dropdown to query explorer and expanded chart view - Fix chart re-render when format changes without data change Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove unneeded return in systeminfo hwinfo util - Use checked_div instead of manual division guard (macos summary) - Gate dump_dashboards behind xtask-commands feature to match caller - Gate Kpi re-export behind cfg(test) since only used in test code - Collapse nested if into match guard (mcp anomaly detection) - Use sort_by_key with Reverse instead of sort_by (mcp) - Suppress deprecated Histogram::percentiles warning (pending migration) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The upstream metriken-query crate removed the hardcoded cpu_cores special case that ignored label filters and forced scalar return. Revert the sum(cpu_cores) workaround in dashboard queries back to bare cpu_cores, and regenerate dashboard JSONs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thinkingfish
force-pushed
the
viewer-multi-node-fixes
branch
from
822019f to
8a0abfb
Compare
Picks up timestamp alignment fix that snaps TSDB timestamps to sampling interval boundaries, eliminating spurious nulls in binary operations between metrics from different samplers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The metadata section in the sidebar makes the top nav dropdown redundant. Remove the chevron, popup table, click handler, metadataExpanded state, and related CSS/helpers.
thinkingfish
changed the title
cpu_cores is an unlabeled gauge, so sum() is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadSectioncall and re-export node helpersTest plan
cargo buildpassescargo clippyclean (zero warnings)🤖 Generated with Claude Code