Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

transfer = ProposedTransaction(...) naming convention doesn't follow other libs #72

@alon-e

Description

@alon-e

both in iota.lib.js and iota.lib.java there are explicit transfer objects.
iota.lib.js
iota.lib.java

however, in iota.lib.py these objects are constructed with iota.ProposedTransaction(...), which is also used as an intermediary representation of transactions & bundles.
from examples:
https://github.com/iotaledger/iota.lib.py/blob/master/examples/send_transfer.py#L24

this is confusing for users moving from other library implementations. like myself. :)


I propose a new class named Transfer, that inherits from ProposedTransaction and is functionally the same, but adheres to the naming conventions of the other libs. (without breaking code that already uses ProposedTransaction of course).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions