This repository was archived by the owner on Jan 13, 2023. It is now read-only.
PY2 Compatibility Code Cleanup #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todofixthis
suggested changes
Mar 10, 2020
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
Dependencies in setup.py need to be updated + minor suggestions.
Python 2 is no longer supported in PyOTA. Remove glue code that made it possible to run the same code on both versions, as it is no longer needed. Changes: - Remove imports from `six` package - Remove imports from `__future__` package - Add some Py3 syntax - Remove encoding spec from files as PY3's default is utf-8 - Update setup.py, simplify dependencies, include metadata in the built sdist and wheel about supported python version - Remove `noinspection` comments
This was referenced Mar 19, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #308 #301
Description
With #301 Python 2 (and Python 3.5) is no longer supported in PyOTA.
This PR removes glue code that made it possible to run the same code on both python versions, as it is no longer needed.
Changes:
sixpackage, andsixis no longer a pyota dependency.__future__package. (was needed for string handling, absolute imports, different division syntax and print function)random.choices, etc.)