This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Introduce Type Annotations #321
Merged
+1,369
−1,370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove type hints. - Follow PEP-484 and PEP-8.
todofixthis
approved these changes
Mar 19, 2020
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
LGTM w/ questions+suggestions+thoughts.
todofixthis
approved these changes
Mar 19, 2020
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
LGTM w/ questions+suggestions+thoughts.
Co-Authored-By: Phoenix <todofixthis@users.noreply.github.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#308, #317
Description
Introduce type annotations to enhance code readability and help static type checking and code analysis tools (mypy, PyCharm, etc.).