Skip to content

Conversation

@obany
Copy link
Contributor

@obany obany commented Mar 9, 2021

Description of change

The amount units dropdown did not work, because some styles had been inadvertently removed.
The amount typed in the box now has more validation, as units of "i" cannot have decimal places.

Links to any relevant issues

Fixes #298

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Tested on windows, with multiple units and amounts

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@obany obany requested a review from cvarley100 as a code owner March 9, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send amount has no indication for wrong formats

4 participants