chore(CI): Add release notes check #6682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaughterOfMars
requested review from
a team,
Dr-Electron,
alexsporn,
msarcev and
thibault-martinez
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
iota-ci
added
dev-tools
muXxer
approved these changes
May 6, 2025
Dr-Electron
approved these changes
Jun 6, 2025
Member
I am not too sure about this, why? Seems annoying. |
Member
A reminder for people that may have forgot to fill it? |
| ) | ||
|
|
||
| if not any_checked and len(notes) > 0: | ||
| issues.append(f" - No checked items in release notes"); |
Member
There was a problem hiding this comment.
Does this mean it will fail if we left the templates notes empty? IMO we shouldn't check that, sounds very annoying.
Contributor
Author
There was a problem hiding this comment.
You should remove it if you don't have any release notes
Member
There was a problem hiding this comment.
I disagree, but I approved anyway. We'll revert when/if too many people complain.
thibault-martinez
approved these changes
Aug 13, 2025
roman1e2f5p8s
pushed a commit
that referenced
this pull request
Aug 28, 2025
# Description of change Adds a job which ensures that PR release notes are correct. It also now enforces that release notes have no empty check boxes, so in the case where there are no notes, the section should be deleted. --------- Co-authored-by: Thibault Martinez <thibault@iota.org>
roman1e2f5p8s
pushed a commit
that referenced
this pull request
Aug 28, 2025
# Description of change Adds a job which ensures that PR release notes are correct. It also now enforces that release notes have no empty check boxes, so in the case where there are no notes, the section should be deleted. --------- Co-authored-by: Thibault Martinez <thibault@iota.org>
roman1e2f5p8s
pushed a commit
that referenced
this pull request
Aug 28, 2025
# Description of change Adds a job which ensures that PR release notes are correct. It also now enforces that release notes have no empty check boxes, so in the case where there are no notes, the section should be deleted. --------- Co-authored-by: Thibault Martinez <thibault@iota.org> Signed-off-by: Roman Overko <roman.overko@iota.org>
roman1e2f5p8s
pushed a commit
that referenced
this pull request
Aug 28, 2025
# Description of change Adds a job which ensures that PR release notes are correct. It also now enforces that release notes have no empty check boxes, so in the case where there are no notes, the section should be deleted. --------- Co-authored-by: Thibault Martinez <thibault@iota.org> Signed-off-by: Roman Overko <roman.overko@iota.org>
roman1e2f5p8s
pushed a commit
that referenced
this pull request
Aug 28, 2025
# Description of change Adds a job which ensures that PR release notes are correct. It also now enforces that release notes have no empty check boxes, so in the case where there are no notes, the section should be deleted. --------- Co-authored-by: Thibault Martinez <thibault@iota.org>
roman1e2f5p8s
pushed a commit
that referenced
this pull request
Aug 28, 2025
# Description of change Adds a job which ensures that PR release notes are correct. It also now enforces that release notes have no empty check boxes, so in the case where there are no notes, the section should be deleted. --------- Co-authored-by: Thibault Martinez <thibault@iota.org>
roman1e2f5p8s
pushed a commit
that referenced
this pull request
Sep 2, 2025
# Description of change Adds a job which ensures that PR release notes are correct. It also now enforces that release notes have no empty check boxes, so in the case where there are no notes, the section should be deleted. --------- Co-authored-by: Thibault Martinez <thibault@iota.org>
roman1e2f5p8s
pushed a commit
that referenced
this pull request
Sep 2, 2025
# Description of change Adds a job which ensures that PR release notes are correct. It also now enforces that release notes have no empty check boxes, so in the case where there are no notes, the section should be deleted. --------- Co-authored-by: Thibault Martinez <thibault@iota.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds a job which ensures that PR release notes are correct. It also now enforces that release notes have no empty check boxes, so in the case where there are no notes, the section should be deleted.