-
Notifications
You must be signed in to change notification settings - Fork 61
feat(iota-indexer): add reliability.md
#6694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
b3fdec6 to
69a3097
Compare
kodemartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sergiupopescu199, I think some refinements are in order. Please see more specific comments.
Also could you also add a section Metrics with a table mapping a short description to each metric used in the requirements?
Co-authored-by: Konstantinos Demartinos <konstantinos.demartinos@iota.org>
kodemartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a few typo corrections and a nitpick
Co-authored-by: Konstantinos Demartinos <konstantinos.demartinos@iota.org>
Co-authored-by: Konstantinos Demartinos <konstantinos.demartinos@iota.org>
Description of change
To enable better monitoring with Grafana for catching regressions and performance issues, this PR expands on the reliability requirements for the
iota-indexer.Links to any relevant issues
fixes #6374
Type of change
How the change has been tested
No code change was done so as test only basic lists & formatters were used like
dprint fmtwhen creating the file.Note
The MD file does not influence the actual Indexer performance, no further tests were performed.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.
Release Notes