enhancement(types): Add tests module iota-types/object.rs #6714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
12 tasks
Thoralf-M
approved these changes
May 2, 2025
DaughterOfMars
approved these changes
May 2, 2025
muXxer
approved these changes
May 5, 2025
jkrvivian
force-pushed
the
node/upstream-v1.33-1.34/495de
branch
from
7b75d19 to
81349bc
Compare
jkrvivian
merged commit 06eaf8e
into
core-node/upstream-changes/mainnet-1.33.3-1.34.2
32 of 34 checks passed
bingyanglin
pushed a commit
that referenced
this pull request
May 19, 2025
# Description of change Port MystenLabs/sui@495def8 From Sui's commit description: Put tests in sui-types/object.rs in their own module The tests are just floating around in the main module, which presumably means they are also compiled into our production builds? They should go into their own module, guarded by a #[cfg(test] annotation. **Note that some files already include the changes in the Sui commit, thus only 1 file got changed.** ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement
bingyanglin
pushed a commit
that referenced
this pull request
May 20, 2025
# Description of change Port MystenLabs/sui@495def8 From Sui's commit description: Put tests in sui-types/object.rs in their own module The tests are just floating around in the main module, which presumably means they are also compiled into our production builds? They should go into their own module, guarded by a #[cfg(test] annotation. **Note that some files already include the changes in the Sui commit, thus only 1 file got changed.** ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement
muXxer
pushed a commit
that referenced
this pull request
May 28, 2025
# Description of change Port MystenLabs/sui@495def8 From Sui's commit description: Put tests in sui-types/object.rs in their own module The tests are just floating around in the main module, which presumably means they are also compiled into our production builds? They should go into their own module, guarded by a #[cfg(test] annotation. **Note that some files already include the changes in the Sui commit, thus only 1 file got changed.** ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement
muXxer
pushed a commit
that referenced
this pull request
May 28, 2025
# Description of change Port MystenLabs/sui@495def8 From Sui's commit description: Put tests in sui-types/object.rs in their own module The tests are just floating around in the main module, which presumably means they are also compiled into our production builds? They should go into their own module, guarded by a #[cfg(test] annotation. **Note that some files already include the changes in the Sui commit, thus only 1 file got changed.** ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement
muXxer
pushed a commit
that referenced
this pull request
May 28, 2025
# Description of change Port MystenLabs/sui@495def8 From Sui's commit description: Put tests in sui-types/object.rs in their own module The tests are just floating around in the main module, which presumably means they are also compiled into our production builds? They should go into their own module, guarded by a #[cfg(test] annotation. **Note that some files already include the changes in the Sui commit, thus only 1 file got changed.** ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement
muXxer
pushed a commit
that referenced
this pull request
Jun 2, 2025
# Description of change Port MystenLabs/sui@495def8 From Sui's commit description: Put tests in sui-types/object.rs in their own module The tests are just floating around in the main module, which presumably means they are also compiled into our production builds? They should go into their own module, guarded by a #[cfg(test] annotation. **Note that some files already include the changes in the Sui commit, thus only 1 file got changed.** ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement
muXxer
pushed a commit
that referenced
this pull request
Jun 2, 2025
# Description of change Port MystenLabs/sui@495def8 From Sui's commit description: Put tests in sui-types/object.rs in their own module The tests are just floating around in the main module, which presumably means they are also compiled into our production builds? They should go into their own module, guarded by a #[cfg(test] annotation. **Note that some files already include the changes in the Sui commit, thus only 1 file got changed.** ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement
10 tasks
muXxer
pushed a commit
that referenced
this pull request
Jun 3, 2025
…ainnet-1.33.3 to mainnet-1.34.2 (#7195) # Description of change This PR contains a batch of node-team related upstream changes. The changes have been individually reviewed before squash-merging. None of them modify protocol parameters, so a new protocol version is not necessary. This PR should be rebased on top of develop without squashing as it already contains squashed PRs. ## Links to any relevant issues List of included PRs: - #6388 - #6464 - #6714 - #6391 - #6826 - #6832 - #6850 - #6877 - #6894 - #6749 - #6740 List of included upstream commits: - MystenLabs/sui@5fb5da2 - MystenLabs/sui@53244c1 - MystenLabs/sui@495def8 - MystenLabs/sui@dec33d0 - MystenLabs/sui@ee1af5f - MystenLabs/sui@3fd7845 - MystenLabs/sui@89224b4 - MystenLabs/sui@13a60fe - MystenLabs/sui@c36d37a - MystenLabs/sui@cd6dfa4 - MystenLabs/sui@9b46036 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) ### Release Notes - [ ] Protocol: - [x] Nodes (Validators and Full nodes): - Add error types to `num_error` metric - Add `auth_agg_quorum_reached_without_requested_objects` metric - `AuthorityAggregator`: always request for events when asked - Improve clarity of errors for `QuorumDriverError` - `QuorumDriver`: Remove conflicting tx retry logic - Remove metrics: - `quorum_driver_total_err_process_tx_responses_with_nonzero_conflicting_transactions` - `quorum_driver_total_attempts_trying_conflicting_transaction` - `quorum_driver_total_successful_attempts_trying_conflicting_transaction` - `quorum_driver_total_times_conflicting_transaction_already_finalized_when_retrying` - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
filipdulic
pushed a commit
that referenced
this pull request
Jul 16, 2025
# Description of change Port MystenLabs/sui@495def8 From Sui's commit description: Put tests in sui-types/object.rs in their own module The tests are just floating around in the main module, which presumably means they are also compiled into our production builds? They should go into their own module, guarded by a #[cfg(test] annotation. **Note that some files already include the changes in the Sui commit, thus only 1 file got changed.** ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Port MystenLabs/sui@495def8
From Sui's commit description:
Put tests in sui-types/object.rs in their own module
The tests are just floating around in the main module, which presumably
means they are also compiled into our production builds? They should go
into their own module, guarded by a #[cfg(test] annotation.
Note that some files already include the changes in the Sui commit, thus only 1 file got changed.
Links to any relevant issues
Part of #3990
Type of change
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.