Skip to content

Remove unnecessary store ability from AuditTrail struct#246

Merged
itsyaasir merged 1 commit intofeat/audit-trails-devfrom
fix/audit-trail-struct-abilities
Apr 14, 2026
Merged

Remove unnecessary store ability from AuditTrail struct#246
itsyaasir merged 1 commit intofeat/audit-trails-devfrom
fix/audit-trail-struct-abilities

Conversation

@itsyaasir
Copy link
Copy Markdown
Contributor

AuditTrail is only ever used as a top-level shared object via transfer::share_object. It is never wrapped in another struct or stored as a dynamic field, so the store ability serves no purpose and unnecessarily expands the public API surface of the type.

Description of change

Links to any relevant issues

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

AuditTrail is only ever used as a top-level shared object via
transfer::share_object. It is never wrapped in another struct or stored
as a dynamic field, so the store ability serves no purpose and
unnecessarily expands the public API surface of the type.
@itsyaasir itsyaasir merged commit 18217b0 into feat/audit-trails-dev Apr 14, 2026
13 checks passed
@itsyaasir itsyaasir deleted the fix/audit-trail-struct-abilities branch April 14, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant