Rewrite of delete_records_batch and is_record_locked functions#263
Merged
chrisgitiota merged 5 commits intoMay 21, 2026
Merged
Conversation
window_count_based(0) is now forbidden in favor of using window_none() instead to prevent silently misconfigured trails.
…ete-records-batch
itsyaasir
reviewed
May 20, 2026
…surface New validation added: - TimeLock::validate_as_delete_trail_lock() rejects UntilDestroyed. - LockingConfig::validate() now also calls the above on delete_trail_lock. - TrailLocking::update_delete_trail_lock now returns Result<TransactionBuilder<UpdateDeleteTrailLock>, Error> and validates up front. - WASM update_delete_trail_lock propagates the error to JS. - Call sites in audit-trail-rs/tests/e2e/locking.rs, examples/audit-trail/04_configure_locking.rs, and examples/audit-trail/real-world/02_clinical_trial.rs updated with ?. AuditTrailBuilder::finish() and TrailLocking::update(LockingConfig) automatically pick up the new check via LockingConfig::validate() — no signature change needed on those. The tf_components::timelock module also asserts EPastTimestamp on unlock_at/unlock_at_ms when the timestamp is in the past. I did not mirror that: it depends on the on-chain clock at execution time, so a client-side check would either be redundant (if the user picks a far-future timestamp) or wrong (if the transaction is built well before submission and a borderline timestamp lapses).
…records-batch' into chore/security-audit-new-delete-records-batch
itsyaasir
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete_records_batch()andis_record_locked()functions.window_count_based(0)is now forbidden in favor of usingwindow_none()instead to prevent silently misconfigured trails.lockingare validated in the AT Rust libraries public surface