feat(audit-trail): complete capabilities tracking feature#198
Draft
alexruzenhack wants to merge 1 commit into
Draft
feat(audit-trail): complete capabilities tracking feature#198alexruzenhack wants to merge 1 commit into
alexruzenhack wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
alexruzenhack
commented
May 19, 2026
| validUntil: Date | null; | ||
| } | ||
|
|
||
| export const mockCapabilities: Capability[] = [ |
Contributor
Author
There was a problem hiding this comment.
Reviewer Comment: // TODO: [Insert Issue #] Replace this mock data with real capability resolution once the SDK supports it.
This was referenced May 19, 2026
alexruzenhack
commented
May 20, 2026
Contributor
Author
There was a problem hiding this comment.
This must be removed.
alexruzenhack
commented
May 20, 2026
|
|
||
| return ( | ||
| <Panel> | ||
| <div data-testid="tx"> |
Contributor
Author
There was a problem hiding this comment.
Must be data-testid="capabilities".
alexruzenhack
commented
May 20, 2026
Comment on lines
+121
to
+137
| <div className="inline-flex content-between items-center gap-x-2"> | ||
| <Input | ||
| type={InputType.Text} | ||
| placeholder="Holder Address..." | ||
| value={searchTerm} | ||
| onChange={(e) => setSearchTerm(e.target.value)} | ||
| /> | ||
|
|
||
| <div className="flex-shrink-0"> | ||
| {' '} | ||
| {/* This wrapper prevents wrapping */} | ||
| <FiltersControl | ||
| filterValue={filterValue} | ||
| setFilterValue={setFilterValue} | ||
| /> | ||
| </div> | ||
| </div> |
Contributor
Author
There was a problem hiding this comment.
Extract it to filter component.
alexruzenhack
commented
May 20, 2026
Comment on lines
+161
to
+203
| {(hasNextPage || (data && data?.pages.length > 1)) && ( | ||
| <Pagination | ||
| hasFirst={currentPageState[filterValue] !== 0} | ||
| onNext={() => { | ||
| if (isPending || isFetching) { | ||
| return; | ||
| } | ||
|
|
||
| // Make sure we are at the end before fetching another page | ||
| if ( | ||
| data && | ||
| currentPageState[filterValue] === data?.pages.length - 1 && | ||
| !isPending && | ||
| !isFetching | ||
| ) { | ||
| fetchNextPage(); | ||
| } | ||
| dispatch({ | ||
| type: PageAction.Next, | ||
|
|
||
| filterValue, | ||
| }); | ||
| }} | ||
| hasNext={ | ||
| (Boolean(hasNextPage) && Boolean(data?.pages[currentPage])) || | ||
| currentPage < (data?.pages.length ?? 0) - 1 | ||
| } | ||
| hasPrev={currentPageState[filterValue] !== 0} | ||
| onPrev={() => | ||
| dispatch({ | ||
| type: PageAction.Prev, | ||
|
|
||
| filterValue, | ||
| }) | ||
| } | ||
| onFirst={() => | ||
| dispatch({ | ||
| type: PageAction.First, | ||
| filterValue, | ||
| }) | ||
| } | ||
| /> | ||
| )} |
Contributor
Author
There was a problem hiding this comment.
Extract to pagination component.
alexruzenhack
force-pushed
the
feat/audit-trail-roles
branch
from
15bc5c1 to
8828603
Compare
alexruzenhack
force-pushed
the
feat/audit-trail-capabilities
branch
from
79f2be4 to
6b9ebe5
Compare
alexruzenhack
force-pushed
the
feat/audit-trail-roles
branch
from
96e99a1 to
9943bea
Compare
alexruzenhack
force-pushed
the
feat/audit-trail-capabilities
branch
from
6b9ebe5 to
30d47a5
Compare
msarcev
reviewed
May 21, 2026
| queryFn: async () => { | ||
| if (!limit) { | ||
| // Do some validation at the runtime level for some extra type-safety | ||
| // https://tkdodo.eu/blog/react-query-and-type-script#type-safety-with-the-enabled-option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR finalizes the Audit Trail epic by introducing the Capabilities tracking view.
Key Features and Changes
CapabilitiesView.tsxto list active and revoked capabilities held by addresses.mockCapabilities.tsto populate the view. Note: This mock data is used intentionally because the on-chain capability resolution is pending a future SDK release. It allows us to merge and test the UI in the meantime.Screenshot
[Insert Screenshot of the Capabilities View]