Rotation can be initiated by a quorum of an existing committee nodes.#505
Merged
Rotation can be initiated by a quorum of an existing committee nodes.#505
Conversation
Signed-off-by: Karolis Petrauskas <karolis.petrauskas@erisata.lt>
Signed-off-by: Karolis Petrauskas <karolis.petrauskas@erisata.lt>
Signed-off-by: Karolis Petrauskas <karolis.petrauskas@erisata.lt>
dessaya
reviewed
Feb 11, 2025
Comment on lines
+539
to
+543
| rotationPTB := vmtxbuilder.NewAnchorTransactionBuilder(bao.ISCPackage(), bao, c.dkShare.GetAddress()) | ||
| rotationPTB.RotationTransaction(aggr.DecidedRotateTo()) | ||
| rotationPTX := rotationPTB.BuildTransactionEssence(bao.GetStateMetadata(), 0) | ||
| rotationTXD := c.makeTransactionData(&rotationPTX, aggr) | ||
| rotationTXB := c.makeTransactionBytes(rotationTXD) |
Contributor
There was a problem hiding this comment.
So the rotation is no longer responsibility of the VM? In this case we can remove al code related to rotation from there?
dessaya
approved these changes
Feb 11, 2025
Signed-off-by: Karolis Petrauskas <karolis.petrauskas@erisata.lt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.