fix: Format message in JSON format for missing part in wasp-cli#758
Merged
howjmay merged 2 commits intoiotaledger:developfrom Nov 25, 2025
Merged
fix: Format message in JSON format for missing part in wasp-cli#758howjmay merged 2 commits intoiotaledger:developfrom
howjmay merged 2 commits intoiotaledger:developfrom
Conversation
lmoe
requested changes
Nov 10, 2025
tools/cluster/tests/wasp-cli_test.go
Outdated
| re := regexp.MustCompile(`Gas fee charged:\s*(\d+)`) | ||
|
|
||
| for _, line := range outs { | ||
| matches := re.FindStringSubmatch(line) |
Collaborator
There was a problem hiding this comment.
Now that our cli supports structured json outputs, that shouldnt be needed anymore
Member
Author
There was a problem hiding this comment.
I think not all the ### cli commands accept --json. I am solving it
howjmay
force-pushed
the
wasp-cli
branch
7 times, most recently
from
dd50c2f to
b342237
Compare
howjmay
changed the title
cwarnerdev
approved these changes
Nov 25, 2025
Contributor
cwarnerdev
left a comment
cwarnerdev
left a comment
There was a problem hiding this comment.
TestEVMGasPriceMismatch fails but not due to this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.