Skip to content

Conversation

@lizhefeng
Copy link
Contributor

@lizhefeng lizhefeng requested a review from a team as a code owner May 23, 2019 19:30
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #1196 into master will increase coverage by 0.07%.
The diff coverage is 93.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
+ Coverage   54.26%   54.34%   +0.07%     
==========================================
  Files         155      155              
  Lines       12488    12512      +24     
==========================================
+ Hits         6777     6800      +23     
- Misses       4876     4877       +1     
  Partials      835      835
Impacted Files Coverage Δ
api/api.go 64.32% <93.1%> (+0.97%) ⬆️
db/trie/extensionnode.go 59.32% <0%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2c73a...860b2d8. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #1196 into master will increase coverage by 0.07%.
The diff coverage is 93.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
+ Coverage   54.26%   54.34%   +0.07%     
==========================================
  Files         155      155              
  Lines       12488    12512      +24     
==========================================
+ Hits         6777     6800      +23     
- Misses       4876     4877       +1     
  Partials      835      835
Impacted Files Coverage Δ
api/api.go 64.32% <93.1%> (+0.97%) ⬆️
db/trie/extensionnode.go 59.32% <0%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2c73a...860b2d8. Read the comment docs.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #1196 into master will increase coverage by 0.06%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
+ Coverage   54.26%   54.33%   +0.06%     
==========================================
  Files         155      155              
  Lines       12488    12513      +25     
==========================================
+ Hits         6777     6799      +22     
- Misses       4876     4878       +2     
- Partials      835      836       +1
Impacted Files Coverage Δ
api/api.go 64.38% <93.54%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2c73a...84f84b7. Read the comment docs.

Copy link
Contributor

@zjshen14 zjshen14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puncsky pls take a look it make sense to mitigate the issue for iotexscan. Thanks

@lizhefeng lizhefeng merged commit f9b77e2 into iotexproject:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants