-
Notifications
You must be signed in to change notification settings - Fork 357
move config.Consensus to consensus package #3507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Config moved to a separate folder is to prevent circular imports |
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
=======================================
Coverage 75.43% 75.43%
=======================================
Files 247 247
Lines 22845 22845
=======================================
Hits 17233 17233
Misses 4685 4685
Partials 927 927
Continue to review full report at Codecov.
|
|
| "time" | ||
|
|
||
| "github.com/iotexproject/iotex-core/blockchain/genesis" | ||
| "github.com/iotexproject/iotex-core/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this dependency, by breaking inputs to NewConsensusConfig at L42
then we can put the new config.go directly under ./consensus, no need to create an extra folder
I tried,but will get errors like |
|
put this on a brief hold, #3511 should solve the import cycle, try again after 3511 merges |
3511 has merged, pls try again |
Description
This PR contains changes for two issues
Fixes #3504 #3506
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: