Skip to content

Conversation

@millken
Copy link
Contributor

@millken millken commented Aug 25, 2022

Description

as title

Fixes #3504, #3506, #3507, #3541

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@millken millken requested a review from a team as a code owner August 25, 2022 09:15
@Liuhaai
Copy link
Member

Liuhaai commented Aug 26, 2022

@millken test failed

@millken
Copy link
Contributor Author

millken commented Aug 26, 2022

@millken test failed

Thanks, fixed

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #3613 (f1c5c50) into master (a20e489) will decrease coverage by 1.39%.
The diff coverage is 70.07%.

@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
- Coverage   75.43%   74.03%   -1.40%     
==========================================
  Files         247      260      +13     
  Lines       22845    23653     +808     
==========================================
+ Hits        17233    17512     +279     
- Misses       4685     5208     +523     
- Partials      927      933       +6     
Impacted Files Coverage Δ
action/action_deserializer.go 57.14% <ø> (ø)
action/protocol/poll/nativestaking.go 41.08% <0.00%> (-0.65%) ⬇️
action/protocol/poll/staking_command.go 10.71% <0.00%> (ø)
action/protocol/staking/read_state.go 15.38% <0.00%> (ø)
action/protocol/vote/probationlist.go 87.50% <ø> (ø)
api/blocklistener.go 70.73% <0.00%> (ø)
api/websocket.go 5.17% <0.00%> (-0.19%) ⬇️
blockchain/block/block_deserializer.go 71.15% <ø> (ø)
blockchain/blockchain.go 0.89% <0.00%> (ø)
blockchain/filedao/filedao_legacy.go 85.80% <ø> (ø)
... and 118 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

)

func newBlockSyncer(cfg config.BlockSync, chain blockchain.Blockchain, dao blockdao.BlockDAO, cs consensus.Consensus) (*blockSyncer, error) {
func newBlockSyncer(cfg Config, chain blockchain.Blockchain, dao blockdao.BlockDAO, cs *mock_consensus.MockConsensus) (*blockSyncer, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why MockConsensus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocksync is imported in the consensus package, use consensus.Consensus will cause an import cycle error.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

No Coverage information No Coverage information
5.9% 5.9% Duplication

@huangzhiran
Copy link
Member

split to small pr will easier to review

@dustinxie dustinxie closed this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move config.Consensus to consensus package

4 participants