-
Notifications
You must be signed in to change notification settings - Fork 357
remove config in consensus and blocksync #3613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@millken test failed |
Thanks, fixed |
Codecov Report
@@ Coverage Diff @@
## master #3613 +/- ##
==========================================
- Coverage 75.43% 74.03% -1.40%
==========================================
Files 247 260 +13
Lines 22845 23653 +808
==========================================
+ Hits 17233 17512 +279
- Misses 4685 5208 +523
- Partials 927 933 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| ) | ||
|
|
||
| func newBlockSyncer(cfg config.BlockSync, chain blockchain.Blockchain, dao blockdao.BlockDAO, cs consensus.Consensus) (*blockSyncer, error) { | ||
| func newBlockSyncer(cfg Config, chain blockchain.Blockchain, dao blockdao.BlockDAO, cs *mock_consensus.MockConsensus) (*blockSyncer, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why MockConsensus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocksync is imported in the consensus package, use consensus.Consensus will cause an import cycle error.
|
SonarCloud Quality Gate failed.
|
|
split to small pr will easier to review |








Description
as title
Fixes #3504, #3506, #3507, #3541
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: