Skip to content

Conversation

@envestcc
Copy link
Member

Description

as title
base #4700

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc envestcc requested a review from a team as a code owner August 21, 2025 09:49
@envestcc envestcc force-pushed the erigon-store-rewarding branch from 84ef284 to 839333f Compare August 31, 2025 23:24
@envestcc envestcc force-pushed the erigon-store-rewarding branch from 839333f to e4235b1 Compare September 25, 2025 10:27
@envestcc envestcc force-pushed the erigon-store-rewarding branch from e4235b1 to 08cf2b9 Compare September 25, 2025 11:05
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Comment on lines +27 to +29
type ObjectStorageRegistry struct {
contracts map[string]map[reflect.Type]int
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in most of the cases, we don't really need reflect.Type to tell the contract index. maybe, we can have a fallback contract for those without a type:

    contracts map[string]struct{
        types map[reflect.Type]int
        fallback int
    }

Such that for Delete, we can have reflect.Type as an option.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we can delete all the registrations in rewarding protocol, and skip the registration type by type.

@envestcc envestcc closed this Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants