-
Notifications
You must be signed in to change notification settings - Fork 359
store rewarding states to erigon db #4701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
84ef284 to
839333f
Compare
839333f to
e4235b1
Compare
e4235b1 to
08cf2b9
Compare
|
| type ObjectStorageRegistry struct { | ||
| contracts map[string]map[reflect.Type]int | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in most of the cases, we don't really need reflect.Type to tell the contract index. maybe, we can have a fallback contract for those without a type:
contracts map[string]struct{
types map[reflect.Type]int
fallback int
}
Such that for Delete, we can have reflect.Type as an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and we can delete all the registrations in rewarding protocol, and skip the registration type by type.


Description
as title
base #4700
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: