Skip to content

Conversation

@envestcc
Copy link
Member

Description

as title
base #4701

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc envestcc requested a review from a team as a code owner August 21, 2025 10:00
Comment on lines 159 to 164
if ns == SystemNamespace {
return systemcontracts.SystemContracts[systemcontracts.PollCandidateListContractIndex].Address, nil
} else if ns == AccountKVNamespace {
return systemcontracts.SystemContracts[systemcontracts.PollLegacyCandidateListContractIndex].Address, nil
}
return nil, errors.Errorf("invalid namespace %s, expected %s or %s", ns, SystemNamespace, AccountKVNamespace)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@envestcc envestcc merged commit dbf6b00 into iotexproject:master Sep 26, 2025
2 of 4 checks passed
@envestcc envestcc deleted the erigon-store-poll branch September 26, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants