comment out the offending code that's overriding Branch's continueUseActivity #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continueUserActivitycan only be declared once, but both Branch and Callkit declares it. Callkit is installed last so it overrides and executes when the app resumes from deeplink. Then crashes since it's running when not being intended and lacks conditional code to early return if notINStartVideoCallIntentorINStartAudioCallIntent.I've tried to implement "swizzle" for all references to
continueUserActivity, however it's not straightforward since Branch declares a custom function calledcontinueUserActivitythat gets executed by swizzle despite having a different signature. Can't rename that custom function since it's being called internally by something.This code is probably related to starting a call from the native phone recents, not something we're using atm.