Send the data in the VOIP push notification to onAnswer #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…useless 'answer event called successfully'
Collaborator
Author
|
I will leave the webhook stuff commented out, as we can try to use the JS |
jerry2013
reviewed
Feb 25, 2025
jerry2013
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of sending
answer event called successfullytoonAnswer, send the data from the VOIP push notification so we're able to action on data within it. Code is essentially copied 1:1 fromdidReceiveIncomingPushWithPayload#@finallybut without the parsing into JSON string as we don't need to do that.Temporarily comment out
setupAudioSessionin case it conflicts with iosrtc's audio setup.Temporarily comment out calling the webhooks for receive/answer/decline.