Add missing checks for ipcrypt_str_to_ip16#4
Merged
jedisct1 merged 1 commit intoipcrypt-std:mainfrom Feb 3, 2026
Merged
Conversation
I noticed that gcc was complaining about possibly using
uninitialized memory:
```
In file included from /usr/include/string.h:548,
from ipcrypt2.c:37:
In function 'memcpy',
inlined from 'ipcrypt_nd_encrypt_ip16' at ipcrypt2.c:1349:5,
inlined from 'ipcrypt_nd_encrypt_ip_str' at ipcrypt2.c:1388:5:
/usr/include/bits/string_fortified.h:29:10: warning: 'ip16' may be used uninitialized [-Wmaybe-uninitialized]
29 | return __builtin___memcpy_chk (__dest, __src, __len,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
30 | __glibc_objsize0 (__dest));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
ipcrypt2.c: In function 'ipcrypt_nd_encrypt_ip_str':
ipcrypt2.c:1381:13: note: 'ip16' declared here
1381 | uint8_t ip16[16];
| ^~~~
```
which seems indeed possible if the IPv6 address could not be
parsed.
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
Collaborator
|
Indeed, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that gcc was complaining about possibly using uninitialized memory:
which seems indeed possible if the IPv6 address could not be parsed.