Add support for dummy_krnlmon target #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
requested review from
5abeel,
n-sandeep,
nupuruttarwar and
vsureshkumarp
as code owners
ffoulkes
added
minor effort
nupuruttarwar
approved these changes
Apr 5, 2024
Contributor
nupuruttarwar
left a comment
nupuruttarwar
left a comment
There was a problem hiding this comment.
LGTM, please update the branch before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cmake support for the
dummy_krnlmontarget, which was originally implemented in the Bazel build.Its purpose is to link
libkrnlmoninto a dummy executable. It's intended for use in standalone krnlmon builds, to check whether there are any unresolved external references.Also added
SET_RPATHto thedpdk.cmakeandes2k.cmakeconfiguration files. This allows the developer to check for RPATH issues by using thelddcommand to load the dummy application.