Add linux networking support #4
Conversation
| limitations under the License. | ||
| */ | ||
|
|
||
| * Copyright (c) 2022 Intel Corporation. |
There was a problem hiding this comment.
This file should carry the Barefoot copyright as well as the Intel copyright.
It is a derivative of an existing work.
ffoulkes
left a comment
ffoulkes
left a comment
There was a problem hiding this comment.
LGTM.
Most of my comments are meant to be informative. The only point I consider important is that we must preserve copyright notices when we adapt existing intellectual property.
I have no objection if you want to wait until the next iteration to fix the copyright notices, especially if this you are doing little more than carrying over existing code from P4-OVS in this iteration.
Incidentally, if any of the new files were adapted from existing code, you should add their copyright notices back in.
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| * Copyright (c) 2022 Intel Corporation. |
There was a problem hiding this comment.
This file should carry the Barefoot copyright as well as the Intel copyright. It is a derivative of an existing work.
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| * Copyright (c) 2022 Intel Corporation. |
There was a problem hiding this comment.
This file should carry the Barefoot copyright as well as the Intel copyright. It is a derivative of an existing work.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| * Copyright (c) 2022 Intel Corporation. |
There was a problem hiding this comment.
This file should carry the Barefoot copyright as well as the Intel copyright. It is a derivative of an existing work.
| limitations under the License. | ||
| */ | ||
|
|
||
| * Copyright (c) 2022 Intel Corporation. |
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| * Copyright (c) 2022 Intel Corporation. |
| @@ -1,33 +1,29 @@ | |||
| /* | |||
| Copyright 2013-present Barefoot Networks, Inc. | |||
| * Copyright (c) 2022 Intel Corporation. | |||
| @@ -1,46 +1,39 @@ | |||
| /* | |||
| * Copyright 2013-present Barefoot Networks, Inc. | |||
| * | |||
| * Copyright (c) 2022 Intel Corporation. | |||
| @@ -1,11 +1,11 @@ | |||
| /* | |||
| * Copyright 2013-present Barefoot Networks, Inc. | |||
| * Copyright (c) 2022 Intel Corporation. | |||
|
On the next commit, could you please correct the title in the top-level |
Sure, will do |
Sure, let me check about licenses one more time with Namrata and from legal standpoint as well, will take care of license in next commit |
I'm talking about copyright notices, not licenses. They both go into the module header, but they're two different things, governed by different sets of laws. Intel policy says that when we modify an existing work, we add our copyright notice below the existing ones. By omitting the existing copyright notice, we appear to be claiming sole authorship of a work of which we are not the sole author. That's at best tacky, and at worst a violation of copyright law. Intel has a bad reputation in the open source community. We need to be punctilious in our observance, partly to maintain public good will, and partly because respect for intellectual property is an Intel value. Barefoot Networks was the author at the time the work was created. Even though they're part of Intel now, their original declaration of authorship still stands. |
This patch is initial commit to introduce linux networking support in krnlmon. Title: Add linux networking support Signed-off-by: nupuruttarwar <nupur.uttarwar@intel.com>
I agree, will make the changes in the next commit |
Fix defects in ECMP hashing
3 participants
This patch is initial commit to introduce linux
networking support in krnlmon.
Title: Add linux networking support
Signed-off-by: nupuruttarwar nupur.uttarwar@intel.com