Skip to content

Conversation

@ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Aug 12, 2023

  • Remove local find_library() calls.

  • Use sde:: namespace when referencing SDE libraries.

This PR depends on changes made to the P4 driver libraries in networking-recipe.

Copy link

@vsureshkumarp vsureshkumarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

Copy link
Contributor

@n-sandeep n-sandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Remove local find_library() calls.

- Use sde:: namespace when referencing SDE libraries.

Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants