Remove OVS dependency for krnlmon #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ffoulkes please review |
ffoulkes
reviewed
Aug 15, 2022
ffoulkes
reviewed
Aug 15, 2022
ffoulkes
reviewed
Aug 15, 2022
ffoulkes
reviewed
Aug 15, 2022
ffoulkes
reviewed
Aug 15, 2022
ffoulkes
reviewed
Aug 15, 2022
ffoulkes
approved these changes
Aug 15, 2022
This patch does following: - Replace vlog with zlog for krnlmon logging and all other utils used from OVS library. - Fix the copyright notices Title: Remove OVS dependency for krnlmon Signed-off-by: nupuruttarwar <nupur.uttarwar@intel.com>
Contributor
Author
Thanks for the review Derek. I have made the requested improvements. Will take care of zlog-cfg custom location and add ability to modify at runtime as separate PR. |
Namrata-intel
approved these changes
Aug 18, 2022
vsureshkumarp
pushed a commit
that referenced
this pull request
Feb 27, 2023
Modified install(FILES) to use `${CMAKE_INSTALL_INCLUDEDIR}`
instead of `${CMAKE_INSTALL_PREFIX}/include`, so the files
are copied to the staging directory when CMAKE_STAGING_PREFIX
is specified.
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does following:
all other utils used from OVS library.
Title: Remove OVS dependency for krnlmon
Signed-off-by: nupuruttarwar nupur.uttarwar@intel.com