Skip to content

Simplify logic to define SAI_INCLUDE_DIR #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aashishkuma merged 1 commit into from
Nov 8, 2023
Merged

Simplify logic to define SAI_INCLUDE_DIR #71

aashishkuma merged 1 commit into from
Nov 8, 2023

Conversation

@ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Nov 7, 2023

  • There's no need to use find_path(). We know where the include directory should be; all we're doing is confirming that it's correct.

@ffoulkes
Simplify logic to define SAI_INCLUDE_DIR
dcbb9b8 
- There's no need to use find_path(). We know where the include
  directory should be; all we're doing is confirming that it's
  correct.

Signed-off-by: Derek G Foster <derek.foster@intel.com>
@ffoulkes ffoulkes added trivial effort Almost no effort required cmake Affects CMake build system labels Nov 7, 2023
@ffoulkes ffoulkes added the bug Something isn't working label Nov 7, 2023
5abeel
5abeel approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aashishkuma
aashishkuma approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@aashishkuma aashishkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vsureshkumarp
vsureshkumarp approved these changes Nov 8, 2023
View reviewed changes
Copy link

@vsureshkumarp vsureshkumarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

@aashishkuma aashishkuma merged commit cbe4be2 into main Nov 8, 2023
@ffoulkes ffoulkes deleted the sai_include_dir branch March 5, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@5abeel 5abeel 5abeel approved these changes

@vsureshkumarp vsureshkumarp vsureshkumarp approved these changes

@aashishkuma aashishkuma aashishkuma approved these changes

@satish153 satish153 Awaiting requested review from satish153

@nupuruttarwar nupuruttarwar Awaiting requested review from nupuruttarwar

@n-sandeep n-sandeep Awaiting requested review from n-sandeep n-sandeep is a code owner

Assignees

No one assigned

Labels

bug Something isn't working cmake Affects CMake build system trivial effort Almost no effort required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ffoulkes @5abeel @vsureshkumarp @aashishkuma