-
Notifications
You must be signed in to change notification settings - Fork 6
Continue adding Bazel support/4 #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented a Bazel buildsystem to build `switchlink` and run its unit tests. - Separated switch_log.h from switch_utils.h by removing the #include for the former from the latter. Updated source files to include either one or both files, depending on their needs. - Removed or commented out dead code. Addressed compiler warnings. Signed-off-by: Derek G Foster <derek.foster@intel.com>
Added "target-sys/" prefix to #includes for target-sys header files, to fix a problem in the bazel build. Updated dpdk.BUILD and the CMakeLists.txt files to reflect the change. Signed-off-by: Derek G Foster <derek.foster@intel.com>
Add bazelize-* to the branch list for the push workflow Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Recent changes to the ES2K SDE made it incompatible with the legacy interface used by the DPDK and Tofino SDEs. `switchsde` provides an abstract interface that allows krnlmon to interact transparently with both the legacy SDEs and the ES2K SDE. The initial implementation is fairly simple. It provides only the features that are needed to support krnlmon; and it takes advantage of the fact that the symbols have simply been renamed, so no data conversions are necessary (yet). Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
- Defined remaining switchapi/dpdk targets. - Addressed compiler warnings in switchapi_utils. - Defined filegroups for all packages. Signed-off-by: Derek G Foster <derek.foster@intel.com>
2731206 to
e388c07
Compare
Signed-off-by: Derek G Foster <derek.foster@intel.com>
e388c07 to
95fc3e2
Compare
Signed-off-by: Derek G Foster <derek.foster@intel.com>
- Moved testing.cmake from switchlink to main directory, allowing any part of krnlmon to define unit tests. - Moved switchlink tests from testing.cmake to the switchlink cmake listfile. - Added switchsde to cmake build system. Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
5abeel
approved these changes
Mar 19, 2024
Collaborator
5abeel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.