Skip to content

Conversation

@ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Mar 12, 2024

  • Defined remaining switchapi/dpdk targets.
  • Addressed compiler warnings in switchapi_utils.
  • Defined filegroups for all packages.
  • Implemented switchsde unit test.
  • Moved switchlink/testing.cmake to cmake/ and generalized it.
  • Added integrity parameter for SAI download.
  • Moved testing.cmake from switchlink to main directory, allowing any part of krnlmon to define unit tests.
  • Moved switchlink tests from testing.cmake to the switchlink cmake listfile.
  • Addressed unused-variable warnings.
  • Copied .bazelrc from Stratum project.

- Implemented a Bazel buildsystem to build `switchlink` and run
  its unit tests.

- Separated switch_log.h from switch_utils.h by removing the
  #include for the former from the latter. Updated source files
  to include either one or both files, depending on their needs.

- Removed or commented out dead code. Addressed compiler warnings.

Signed-off-by: Derek G Foster <derek.foster@intel.com>
Added "target-sys/" prefix to #includes for target-sys header
files, to fix a problem in the bazel build. Updated dpdk.BUILD and
the CMakeLists.txt files to reflect the change.

Signed-off-by: Derek G Foster <derek.foster@intel.com>
Add bazelize-* to the branch list for the push workflow

Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Recent changes to the ES2K SDE made it incompatible with the
legacy interface used by the DPDK and Tofino SDEs. `switchsde`
provides an abstract interface that allows krnlmon to interact
transparently with both the legacy SDEs and the ES2K SDE.

The initial implementation is fairly simple. It provides only
the features that are needed to support krnlmon; and it takes
advantage of the fact that the symbols have simply been renamed,
so no data conversions are necessary (yet).

Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
- Defined remaining switchapi/dpdk targets.

- Addressed compiler warnings in switchapi_utils.

- Defined filegroups for all packages.

Signed-off-by: Derek G Foster <derek.foster@intel.com>
@ffoulkes ffoulkes added the bazel Affects Bazel build system label Mar 12, 2024
@ffoulkes ffoulkes requested a review from aashishkuma March 12, 2024 18:23
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
- Moved testing.cmake from switchlink to main directory, allowing
  any part of krnlmon to define unit tests.

- Moved switchlink tests from testing.cmake to the switchlink
  cmake listfile.

- Added switchsde to cmake build system.

Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
@ffoulkes ffoulkes added the cmake Affects CMake build system label Mar 15, 2024
@ffoulkes ffoulkes marked this pull request as ready for review March 15, 2024 16:38
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes changed the title Add Bazel support for switchapi/dpdk Add Bazel support for switchapi/dpdk/4 Mar 25, 2024
@ffoulkes ffoulkes changed the title Add Bazel support for switchapi/dpdk/4 Continue adding Bazel support/4 Mar 25, 2024
Base automatically changed from bazel-support-3 to main March 25, 2024 21:22
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
@ffoulkes ffoulkes merged commit f42a58a into main Mar 26, 2024
@ffoulkes ffoulkes deleted the bazel-support-4 branch March 26, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bazel Affects Bazel build system cmake Affects CMake build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants