Port tdi_table_manager change from P4-OVS

[ffoulkes]

• In BuildP4TableEntry, only set the action profile member and group IDs if the action ID is zero, instead of setting them unconditionally.

Signed-off-by: Derek G Foster derek.foster@intel.com

[ravi861]

I presume this is because the log file is inundated with error messages saying $ACTION_MEMBER_ID and $SELECTOR_GROUP_ID are not found. I was also looking to address this. Thanks for taking care of this.
Upstream stratum addressed this differently by making the changes within GetSelectorGroupId and GetActionMemberId.
https://github.com/stratum/stratum/blob/a341191e2b9bda2e700f12d7414b9652b2c4f53e/stratum/hal/lib/barefoot/bf_sde_wrapper.cc#L801

[ravi861]

@saynb Is there any case where there is an action spec present and still containing ACTION_MEMBER_ID or SELECTOR_MEMBER_ID for a table type?

[ffoulkes]

I presume this is because the log file is inundated with error messages saying $ACTION_MEMBER_ID and $SELECTOR_GROUP_ID are not found. I was also looking to address this. Thanks for taking care of this. Upstream stratum addressed this differently by making the changes within GetSelectorGroupId and GetActionMemberId.

Do you prefer one solution over the other?

[ffoulkes]

@saynb Is there any case where there is an action spec present and still containing ACTION_MEMBER_ID or SELECTOR_MEMBER_ID for a table type?

I have no idea. I'm porting someone else's undocumented code changes.

[ravi861]

I presume this is because the log file is inundated with error messages saying $ACTION_MEMBER_ID and $SELECTOR_GROUP_ID are not found. I was also looking to address this. Thanks for taking care of this. Upstream stratum addressed this differently by making the changes within GetSelectorGroupId and GetActionMemberId.

Do you prefer one solution over the other?

This is a safe change in my opinion. We will get the other change anyway when we merge from upstream. LGTM.