Enrich CSV output for detailed_itineraries() #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Seems like O/D with stop_id can be retrieved but don't know if that's index or actual stop_id 2. Weird error when trying to make a list of StreetSegment edgeID when walking. Try to access it by access the public variable edgeId but won't let me. The code should be correct. See test.java for more testing. But could be because of weird cross-package access limitation for java Manage to make the jar work by using a try catch phrase,
… and board stop id is an index, not actual id.
… to accommodate the new update to java 21. didn't succeed.
Contributor
Author
|
Don't know which branch to merge to so I just select main which can be problematic. Just FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated features:
Add OSM link ID. Instead, the output network files via street_network__to_sf will output all links. See
r5r/java-r5rcore/src/org/ipea/r5r/StreetNetwork.java
Line 53 in 934c4ac
Add boarding and alighting stop ID. Output as board_stop_id and alight_stop_id
Since the LINSTRING contains both space and comma, I use tab as the delimitator for the csv file and semicolon as the delimitator for the edge_id_list
Output time measures as second and distance measures as meters