This repository was archived by the owner on Jun 2, 2020. It is now read-only.
Fix: The example of the DHT Buckets#532
Merged
Stebalien merged 1 commit intoipfs-inactive:masterfrom May 28, 2020
youngjoon-lee:patch-1
Merged
Fix: The example of the DHT Buckets#532Stebalien merged 1 commit intoipfs-inactive:masterfrom youngjoon-lee:patch-1
Stebalien merged 1 commit intoipfs-inactive:masterfrom
youngjoon-lee:patch-1
Conversation
As I understand, The `m` needs to be `16` in the example of the DHT Buckets. Please correct me if I didn't understand it correctly. I just began to go through the IPFS documentations.
Stebalien
approved these changes
May 28, 2020
Contributor
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
This entire section is slightly incorrect as buckets are really just an abstraction for organizing peers in a routing table.
But your change makes this strictly more correct.
Contributor
|
Note: this repo is being deprecated. The new page is at https://github.com/ipfs/docs/blob/master/content/guides/concepts/dht.md. Would you mind making a PR against that repo as well? |
Collaborator
|
It looks like this merge just triggered the CI again, replacing the current
docs site. Someone will need to manually switch the CID again.
I don’t have admin rights to disconnect this repo
…On Thu, 28 May 2020 at 22:13, Steven Allen ***@***.***> wrote:
Note: this repo is being deprecated. The new page is at
https://github.com/ipfs/docs/blob/master/content/guides/concepts/dht.md.
Would you mind making a PR against that repo as well?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#532 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA2DOWJ4KVJYIRRYJ24543RT3HXZANCNFSM4NMWWA3A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I understand, The
mneeds to be16in the example of the DHT Buckets.Please correct me if I didn't understand it correctly. I just began to go through the IPFS documentations.