Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Conversation

@thisconnect
Copy link
Contributor

JavaScript implementation would only log the tree for 'a' which would log []

Pretty sure this is an example bug

@ghost ghost assigned thisconnect Oct 23, 2017
@ghost ghost added the in progress label Oct 23, 2017
@thisconnect thisconnect requested a review from daviddias October 23, 2017 07:15
@thisconnect
Copy link
Contributor Author

also the result is an array, should I update this?

ipfs.dag.tree('zdpuAmtur968yprkhG9N5Zxn6MFVoqAWBbhUAkNLJs2UtkTq5', errOrLog)
// Logs:
// a
// b
// b/0
// b/1
// b/2
// c
// c/ca
// c/ca/0
// c/ca/1
// c/ca/2
// c/cb

In js-ipfs it is:

// Logs:
// [ 'a',
//   'b',
//   'b/0',
//   'b/1',
//   'b/2',
//   'c',
//   'c/ca',
//   'c/ca/0',
//   'c/ca/1',
//   'c/ca/2',
//   'c/cb' ]

@thisconnect
Copy link
Contributor Author

@daviddias daviddias merged commit 499cd9e into ipfs-inactive:master Oct 23, 2017
@daviddias
Copy link
Contributor

thanks for catching this @thisconnect :)

@thisconnect
Copy link
Contributor Author

My first time playing with js-ipfs, instead of js-ipfs-api + go-ipfs. It's great to have dag api :) works nicely so far.

@daviddias
Copy link
Contributor

That's great feedback, thank you :D Let me know as you find other things :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants