This repository was archived by the owner on Mar 10, 2020. It is now read-only.
refactor: relax check for undefined property #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `x` has a property explicitly set to `undefined` then `expect(x).to.eql(y)` requires `y` to also have a property set to undefined. This PR relaxes that requirement to also allow `y` to simply not have the property. This is to save having to explicitly re-define this property to undefined when y has been `JSON.stringify`'d. This happens in the ipfs-postmsg-proxy and this change removes the need for the proxy to know the shape of this object (or at least which properties might have been undefined). License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
xhas a property explicitly set toundefinedthenexpect(y).to.eql(x)requiresyto also have a property set to undefined. This PR relaxes that requirement to also allowyto simply not have the property.This is to save having to explicitly re-define this property to undefined when
yhas beenJSON.stringify'd. This happens in the ipfs-postmsg-proxy and this change removes the need for the proxy to know the shape of this object (or at least which properties might have been undefined).