This repository was archived by the owner on Mar 10, 2020. It is now read-only.
chore: increase ping timeouts #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes around 15s locally and can take significantly longer in CI. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned
Contributor
|
shouldn't we try to improve the code instead of just increasing the mocha timeout ? This shouldn't take this long right 2 * 60 * 1000? |
Contributor
Author
|
The screenshot above is from js-ipfs-api talking to a go-ipfs node. Most of the time it takes ~15s but occasionally it takes >1min in CI. I'll open an issue on the go-ipfs repo. |
Contributor
Author
hugomrdias
approved these changes
Nov 28, 2018
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Contributor
Author
|
@hugomrdias I've added comments with link to the issue. I'm going to merge this so that our ping tests become more reliable and we can revisit when the issue is resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes around 15s locally and can take significantly longer in CI.