Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

docs: object.patch.addLink param must have cid prop #422

Merged
achingbrain merged 1 commit into from
Dec 17, 2018
Merged

docs: object.patch.addLink param must have cid prop #422

achingbrain merged 1 commit into from
Dec 17, 2018
+4 −4

Conversation

@olizilla
Copy link
Contributor

@olizilla olizilla commented Dec 17, 2018 •
edited
Loading

  • we hit this while refactoring web ui to use the latest ipfs-http-client.
  • also fixes incorrectly terminated code fence for rmLink.

@olizilla
docs: object.patch.addLink param must have cid prop
c9c123d 
also fixes incorrectly terminated code fence for rmLink
@ghost ghost assigned olizilla Dec 17, 2018
@ghost ghost added the in progress label Dec 17, 2018
@olizilla olizilla requested a review from alanshaw December 17, 2018 13:13
achingbrain
achingbrain approved these changes Dec 17, 2018
View reviewed changes
Copy link
Collaborator

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achingbrain achingbrain merged commit 0246f14 into master Dec 17, 2018
@ghost ghost removed the in progress label Dec 17, 2018
@achingbrain achingbrain deleted the update-addlink-api branch December 17, 2018 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alanshaw alanshaw Awaiting requested review from alanshaw

1 more reviewer

@achingbrain achingbrain achingbrain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@olizilla olizilla

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olizilla @achingbrain