This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix: make invalid url actually invalid #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using one of those ISPs that 'helpfully' directs you to a search page if the URL you are accessing does not have a DNS match. The URL used in the test was well formed but not a real domain though can be resolved, so this PR changes it to be something even a web-breaking DNS server would refuse to resolve.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using one of those ISPs that 'helpfully' directs you to a search page if the URL you are accessing does not have a DNS match.
The URL used in the test was well formed but not a real domain though can be resolved, so this PR changes it to be something even a web-breaking DNS server would refuse to resolve.