This repository was archived by the owner on Mar 10, 2020. It is now read-only.
object patch add-link: don't force to have a Buffer for 'ref' #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also while I was looking at the code, I saw that in a lot of place there is a call to |
daviddias
approved these changes
Jul 22, 2017
Contributor
daviddias
left a comment
daviddias
left a comment
There was a problem hiding this comment.
was failing linting. Fixed. LGTM. Thanks @MichaelMure !
Contributor
Author
|
@diasdavid what about my question just above ? #578 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to send a multi-hash as a string as well.