Skip to content
This repository was archived by the owner on Jul 5, 2021. It is now read-only.

feat(topnav): add Discuss, remove Media#306

Merged
olizilla merged 2 commits intomasterfrom
feat/discuss
May 15, 2019
Merged

feat(topnav): add Discuss, remove Media#306
olizilla merged 2 commits intomasterfrom
feat/discuss

Conversation

@lidel
Copy link
Copy Markdown
Contributor

@lidel lidel commented May 14, 2019

This PR aims to address immediate need raised in #236 (comment):

We should have a prominent HOW TO GET HELP item that send people to discuss. While there is extensive documentation on how to contribute and help others, there is no reference to how actually get help from others.

Discuss is a good async place to direct people at until we have a proper
"Community" / "Comms" landing page, similar to "Teams"

"Media" should not be in the top nav, it was not updated for a long time
and gives bad impression of stale development.

Supersedes #276
CC #236
@Stebalien
Copy link
Copy Markdown
Contributor

SGTM but I'd rather have a "Help" or "Community" landing page (not sure how much work that is).

@lidel
Copy link
Copy Markdown
Contributor Author

lidel commented May 14, 2019

Yup, this is just a temporary fix until proper landing page is added.

@olizilla ok to merge this?

@cwaring
Copy link
Copy Markdown
Contributor

cwaring commented May 14, 2019

I'd suggest we use Discuss or Forum for the links, but not both. Forum gets my vote because it's descriptive to what it is and not related to the product name.

@Stebalien: I agree this should be a page, happy to add that task to my list.

Otherwise, LGTM :shipit:

@hsanjuan
Copy link
Copy Markdown
Member

Forum or Help

Comment thread layouts/partials/header.html Outdated
<li><a href="/team" {{ if eq .page.Type "team" }}class="current-item"{{ end }}>Team</a></li>
<li><a href="/media" {{ if eq .page.Type "media" }}class="current-item"{{ end }}>Media</a></li>
<li><a href="//blog.ipfs.io/" {{ if or (eq .page.Type "blog") (eq .page.Data.Singular "author") }}class="current-item"{{ end }}>Blog</a></li>
<li><a href="//discuss.ipfs.io">Discuss</a></li>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would put Forum here. Discuss probably does not mean much to many people.

@olizilla
Copy link
Copy Markdown
Collaborator

Let's go with Forum for now, and we'll look at adding a help/community page next.

Copy link
Copy Markdown
Collaborator

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olizilla olizilla merged commit 5605f91 into master May 15, 2019
@olizilla olizilla deleted the feat/discuss branch May 15, 2019 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a prominent reference to discuss.ipfs.io from the docs page(s)

6 participants