fix: remove wants from wantlist when multiple block retrievers are used#491
Merged
achingbrain merged 2 commits intomainfrom Apr 9, 2024
Merged
fix: remove wants from wantlist when multiple block retrievers are used#491achingbrain merged 2 commits intomainfrom
achingbrain merged 2 commits intomainfrom
Conversation
Fixes a bug where sometimes a wanted CID was not removed from the wantlist. Also switches to using events for block/presence arrival to remove shared promises.
achingbrain
changed the title
achingbrain
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where sometimes a wanted CID was not removed from the wantlist when it was retrieved by an alternative block retriever.
Also switches to using events for block/presence arrival to remove shared promises.
Change checklist