Skip to content

Conversation

dome
Copy link
Contributor

@dome dome commented Aug 9, 2022

Add 8api.sh peers

@welcome
Copy link

welcome bot commented Aug 9, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
  • Your contribution itself is clear (grammar and spelling checked, any code blocks checked and commented) and in its best form. Follow the docs contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
  • The PR gets reviews, discussed and approvals as needed.
  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Contributor

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the submission @dome. I can ping the first one but not the second

@johnnymatthews
Copy link
Contributor

I also get responses from both peers:

$ › ipfs ping 12D3KooWGASC2jm3pmohEJXUhuStkxDitPgzvs4qMuFPaiD9x1BA                                                 ~
Looking up peer 12D3KooWGASC2jm3pmohEJXUhuStkxDitPgzvs4qMuFPaiD9x1BA
PING 12D3KooWGASC2jm3pmohEJXUhuStkxDitPgzvs4qMuFPaiD9x1BA.
Pong received: time=112.23 ms
Pong received: time=112.12 ms
Pong received: time=111.36 ms
Average latency: 111.90ms

$ › ipfs ping 12D3KooWRbWZN3GvLf9CHmozq4vnTzDD4EEoiqtRJxg5FV6Gfjmm                                                 ~
Looking up peer 12D3KooWRbWZN3GvLf9CHmozq4vnTzDD4EEoiqtRJxg5FV6Gfjmm
PING 12D3KooWRbWZN3GvLf9CHmozq4vnTzDD4EEoiqtRJxg5FV6Gfjmm.
Pong received: time=131.11 ms
Pong received: time=129.09 ms
Pong received: time=129.70 ms
Average latency: 129.97ms

@TMoMoreau
Copy link
Contributor

8api.sh isn't known to us, are you affiliated with the IPFS team in any way?

@TMoMoreau TMoMoreau added the need/author-input Needs input from the original author label Aug 16, 2022
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022-08-26: agreed to merge because this isn't making things worse. We do think this file should be rethought.

@BigLep BigLep merged commit 517ed21 into ipfs:main Aug 26, 2022
2color added a commit that referenced this pull request Aug 29, 2022
* origin:
  Update peering-with-content-providers.md (#1235)
  rephrase quote
  fix: typo and image position
  Adds plausible analytics to IPFS docs.
  Address feedback from Fabien
  Address feedback
  Apply suggestions from code review
  Automatically optimized images [ci skip].
  Add snapshot case study to sidebar and concepts page
  Add Snapshot to usage ideas and examples
  Add Snapshot case study
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need/author-input Needs input from the original author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants